Only create stream_context if curl is not used #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In __call, the variables $opts and $context were initialized even if they were not needed. This commit remedies this by moving their initialization to the else-branch of the if-statement that checks if curl can be used.
weberhofer
added a commit
that referenced
this pull request
Jul 7, 2015
Only create stream_context if curl is not used. Thank you, @dajero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly, this is not a dramatic improvement, but I changed this as I was working on something else.
Before, __call would initialize the $opts and $context variables that are only used by fopen, not cURL. This commit places their initialization in the else-branch of the if-statement that determines if cURL can be used.