Update unclear chained struct names for better readability #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kainino0x @rajveermalviya Please review |
|
(gentle ping) |
kainino0x
approved these changes
Aug 26, 2024
| struct WGPUSurfaceFromXcbWindow; | ||
| struct WGPUSurfaceFromXlibWindow; | ||
| struct WGPUSurfaceSourceAndroidNativeWindow; | ||
| struct WGPUSurfaceSourceCanvasHTMLSelector_Emscripten; |
There was a problem hiding this comment.
IIRC we actually want to remove this from this header (we'll make it an Emscripten-exclusive addon for now) but that doesn't need to block this PR.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 30, 2024
- No operational changes. webgpu-native/webgpu-headers#309 webgpu-native/webgpu-headers#310 webgpu-native/webgpu-headers#318 Bug: 42241174 Change-Id: I635d420c58a061bf463d3d319b7f0d60a867bcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5691772 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/main@{#1349098}
hubot
pushed a commit
to google/skia
that referenced
this pull request
Sep 3, 2024
- No operational changes. webgpu-native/webgpu-headers#309 webgpu-native/webgpu-headers#310 webgpu-native/webgpu-headers#318 Bug: 42241174 Change-Id: Ia881b48c222b6448fc1e9682e542d4172eaf3958 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/874956 Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Auto-Submit: Fr <beaufort.francois@gmail.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 5, 2024
- No operational changes. webgpu-native/webgpu-headers#309 webgpu-native/webgpu-headers#310 webgpu-native/webgpu-headers#318 Bug: 42241174 Change-Id: Ifff832f518f280178842ded7e5879e741a48ec41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5830449 Auto-Submit: Fr <beaufort.francois@gmail.com> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1351225}
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Sep 5, 2024
The following CLs must be merged before: - https://chromium-review.googlesource.com/c/chromium/src/+/5691772 - https://chromium-review.googlesource.com/c/chromium/src/+/5830449 - https://skia-review.googlesource.com/c/skia/+/874956 webgpu-native/webgpu-headers#309 webgpu-native/webgpu-headers#310 webgpu-native/webgpu-headers#318 Bug: 42241174 Change-Id: I669228181719c15beb23cd3b0545f5521e004339 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197476 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 6, 2024
- No operational changes. webgpu-native/webgpu-headers#309 webgpu-native/webgpu-headers#310 webgpu-native/webgpu-headers#318 Bug: 42241174 Change-Id: Ic0dacce67f395c4b3b89c0d48fd12680c5b9d48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829207 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1351933}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #212 (comment), this PR updates unclear chained struct names (and their respective SType) for better readability.
It also fixes WGPURenderPassMaxDrawCount SType.