-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp 39 pzp secure web socket #489
base: master
Are you sure you want to change the base?
Conversation
It looks like the PZH isn't returning a 'success' result when it runs with the --test command. This is why the travis build is failing. |
Fixed the callback.. |
Enrolment seems broken for me. On Firefox, I hang at "Your device is being enrolled at the PZH". It's also not a very fun user experience for Firefox. |
any message you see in your console. |
@@ -773,7 +824,82 @@ var PzpWSS = function (parent) { | |||
self.sendConnectedApp (key, msg); | |||
} | |||
} | |||
} | |||
}; | |||
this.storeCertificateBrowser = function(enrolled) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this didn't work? Should it be called, or is it going to be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept it for a later purpose. If somebody can experiment further with store certificate in browser, this code could be useful.
The Travis CI Build is still failing. When I run 'npm test' I get the same behaviour. Can you fix this? |
Configuration has generic function to store data in files. PZP generates 3 sets of certificates PZPCA (at enrollment signed by PZH), PZP connection certificate and PZP web socket certificate. Jira Issue: WP-39
…12util PZP now runs on secure web socket connection and uses mutual authentication. Certificates are stored in chrome and mozilla database currently. Jira Issue: WP-39
Storing in browser database will not scale on different platforms. The adverse effect of this solution will be browser not mutual authenticated. It does not stop PZP from using secure websocket. Jira Issue: WP-39
Jira Issue: WP-39
Jira Issue: WP-39
Jira Issue: WP-39
@jplyle can you merge this? |
I need more time to test this, or someone else does. It's a non-trivial change. Sorry! |
No issue. Suggested as thought travis build was the issue. |
This is failing for me with Linux + Firefox + a Google account. Enrolment stalls at "Currently your device is being enrolled at the PZH..." PZP output: Zephyr HRM driver - register new elements Fake driver 1 - register new elements Fake driver 2 - register new elements PZH output: [7.3.2013-12:4:2:706] info pzh_webSessionHandling.js(524) adding new zone hub - 172.16.253.150_johnplyle@googlemail.com |
I also suggest this needs corresponding documentation changes, too. |
Which firefox you have. I have tested on 19. |
That probably explains it - I'm on 18.0.2. On 07/03/13 14:00, Habib Virji wrote:
|
Starts PZP using secure websocket connection
Generates separate certificate for the PZP WebSocket server.
Requires starting PZP with https instead of http to access localhost.
Jira Issue: WP-39