Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates, Maven plugin updates, refactorings and cleanups #12

Merged
merged 7 commits into from
Feb 21, 2022

Conversation

dheid
Copy link
Contributor

@dheid dheid commented Feb 18, 2022

Hi @jamesward !

Again some dependency updates, refactorings, Maven plugin updates and stuff to the WebJars locator

Perhaps the most important change is the usage of Mustache template engine to generate the setup JavaScript snippet using a template file.

Best regards

Daniel

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@jamesward
Copy link
Member

Thanks for this! My only concern with this is the runtime templating having a performance impact. I'd rather switch this to a compile time template. Maybe there is a Maven plugin to compile the mustache template at compile time?

@dheid
Copy link
Contributor Author

dheid commented Feb 21, 2022

Mustache is extremly fast and the template is cached once it was requested for a specific path. Sadly you cannot precompile the template, since most of it will be build according to the WebJar classpath elements. So from my understanding we cannot compile it in advance. It won't be much slower than the previous string concatenation.

See also: https://github.com/mbosecke/template-benchmark

@jamesward
Copy link
Member

Ah cool. Since it gets cached, that is sufficient reason. Thanks for the details!

@jamesward jamesward merged commit f08cdea into webjars:master Feb 21, 2022
@jamesward
Copy link
Member

I'm releasing 0.43 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants