Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

Commit

Permalink
docs: update gotchas (#284)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ricardogobbosouza @evilebottnawi
ricardogobbosouza authored and evilebottnawi committed Jul 4, 2019
1 parent 2a72daa commit 8cb02a6
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,11 @@ module.exports = {

## Gotchas

### NoErrorsPlugin
### NoEmitOnErrorsPlugin for `webpack >= 4`

`NoEmitOnErrorsPlugin` is now automatically enabled in webpack 4, when mode is either unset, or set to production. So even ESLint warnings will fail the build. No matter what error settings are used for `eslint-loader`, except if `emitWarning` enabled.

### NoErrorsPlugin for `webpack < 4`

`NoErrorsPlugin` prevents webpack from outputting anything into a bundle. So even ESLint warnings
will fail the build. No matter what error settings are used for `eslint-loader`.
Expand All @@ -316,7 +320,9 @@ See [#129](https://github.com/webpack-contrib/eslint-loader/issues/129).
---

## Changelog

[Changelog](CHANGELOG.md)

## License

[MIT](./LICENSE)

0 comments on commit 8cb02a6

Please sign in to comment.