Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emit warning error quiet #46

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Fix emit warning error quiet #46

merged 5 commits into from
Jan 25, 2021

Commits on Jan 23, 2021

  1. test: add full-of-problems test from eslint example 

    - https://eslint.org/docs/user-guide/formatters/#eslint-formatters
- This provides a single file with a variety of errors and warnings
    @michaelangeliu
    michaelangeliu committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    5ca6e14 View commit details
    Browse the repository at this point in the history

  2. test: add test using full-of-problems and quiet flag 

    - when linting a file that has both warnings and errors, if
the quiet flag is set, then the errors should be emited, but
the warnings should not
    @michaelangeliu
    michaelangeliu committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    66b8359 View commit details
    Browse the repository at this point in the history

  3. test: add emit-error and emit-warning tests 

    - replace force-emit-error and force-emit-warning tests with more
robust tests that match the functionality of eslint-loader
- if emitError is undefined or true, it should emit errors, otherwise
if emitError is false, it should suppress errors
- if emitWarning is undefined or true, it should emit warnings, otherwise
if emitWarning is false, it should suppress warnings
    @michaelangeliu
    michaelangeliu committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    a1f4838 View commit details
    Browse the repository at this point in the history

  4. fix: suppress warnings when emitWarning is set to false 

    - print errors only when emitError is undefined or true,
otherwise suppress errors
- print warnings only when emitWarning is undefined or true,
otherwise suppress warnings
- this allows the config to be set up to lint a file that has
both warnings and errors and only show the relevant errors or
warnings

fix webpack-contrib#19

BREAKING CHANGE: Updates to emitError and emitWarning

Setting only emitError to true will no longer exclusively print files with errors
and disregard the files with warnings. Similarly, setting only emitWarning to true
will no longer exclusively print files with warnings disregard the files with errors.
    @michaelangeliu
    michaelangeliu committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    264644c View commit details
    Browse the repository at this point in the history

  5. fix: use quiet to override emitError and emitWarning 

    - quiet is essentially syntactic sugar for setting emitError to true
and emitWarning to false

fix webpack-contrib#19
    @michaelangeliu
    michaelangeliu committed Jan 23, 2021
    Configuration menu
    Copy the full SHA
    ec0d635 View commit details
    Browse the repository at this point in the history