fix: refer to the `entrypoint` instead of the first `module` (`module.identifier`) #601

akihikodaki · 2017-08-14T15:47:16Z

The order of modules can be reordered by optimize-module-order plugins. The intention is to use the entry point as the default identifier, so refer to entries property of the compilation.

jsf-clabot · 2017-08-14T15:47:18Z

All committers have signed the CLA.

codecov · 2017-08-14T15:59:19Z

Codecov Report

Merging #601 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   87.41%   87.45%   +0.04%     
==========================================
  Files           7        7              
  Lines         302      303       +1     
  Branches       68       68              
==========================================
+ Hits          264      265       +1     
  Misses         36       36              
  Partials        2        2

Impacted Files	Coverage Δ
src/loader.js	`88.88% <100%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5286ab2...f2c3056. Read the comment docs.

alexander-akait

Can your describe more information (test repo would be best), also add tests for this, thanks!

akihikodaki · 2017-08-15T00:08:01Z

Commit 426e758 adds a test case.

akihikodaki · 2017-08-15T00:28:52Z

`Issues`

Fixes Breaks with NamedModulesPlugin #648

sgal · 2017-10-19T17:00:52Z

Also fixes webpack/webpack#5733

akihikodaki · 2017-10-20T13:35:34Z

52a1942 applies #601 (review).

michael-ciniawsky

@akihikodaki Thx

joshwiens · 2017-10-20T14:58:30Z

@akihikodaki - Once #652 lands, this will need one more quick rebase before it merges.

michael-ciniawsky · 2017-10-20T16:02:59Z

@akihikodaki #652 just landed please rebase when time :)

akihikodaki · 2017-10-21T01:34:11Z

8228819: rebased to 5286ab2.

michael-ciniawsky · 2017-10-21T01:58:45Z

Module build failed: TypeError: entries[0].identifier is not a function

@akihikodaki Can you revert to compilation.entries[0].identifier ? Or create a new variable etc ?

…tifier The order of modules can be reordered by optimize-module-order plugins. The intention is to use the entry point as the default identifier, so refer to entries property of the compilation.

akihikodaki · 2017-10-21T02:28:31Z

f2c3056: Reverted the change. I reviewed the intension why I used compilation.entries, and it was actually because entries argument is not an array of the first modules to be executed, but of chunks.

michael-ciniawsky · 2017-10-21T02:40:16Z

extract-text-webpack-plugin/src/loader.js

Line 81 in f2c3056

childCompiler.runAsChild((err, entries, compilation) => {

did you add this 🙃 ? The entries argument seems to be unused

akihikodaki · 2017-10-21T10:51:08Z

No, I didn't.

cletusw · 2017-10-21T15:31:54Z

Thanks! Could someone post here when we get a release bump with this fix?

sgal · 2017-10-25T07:38:37Z

Is there any plan to release a new version with this fix? The issue with NamedModulesPlugin and HashedModuleIdsPlugin is preventing users from implementing long term caching, so it would be nice to get it out.

alexander-akait suggested changes Aug 14, 2017

View reviewed changes

alexander-akait added flag: Needs Docs priority: 5 (nice to have) semver: Patch type: Bug flag: Needs more info and removed flag: Needs Docs labels Aug 14, 2017

akihikodaki force-pushed the master branch from 7a036d0 to 426e758 Compare August 15, 2017 00:07

yumetodo mentioned this pull request Aug 15, 2017

大体全部のhtmlが全部同じになっている。 miraiken/web#78

Closed

alexander-akait requested review from bebraw, michael-ciniawsky and joshwiens August 15, 2017 08:45

michael-ciniawsky changed the title ~~Refer to the entry point instead of the first module for default identifier~~ refactor: refer to the entry point instead of the first module (module.identifier) Aug 16, 2017

sgal mentioned this pull request Sep 28, 2017

get wrong css order after using HashedModuleIdsPlugin webpack/webpack#5733

Closed

sgal mentioned this pull request Oct 19, 2017

Breaks with NamedModulesPlugin #648

Closed

sokra approved these changes Oct 19, 2017

View reviewed changes

sokra reviewed Oct 19, 2017

View reviewed changes

michael-ciniawsky added pr_action: Review status: Approved and removed flag: Needs more info priority: 5 (nice to have) labels Oct 19, 2017

michael-ciniawsky added this to the 3.0.1 milestone Oct 19, 2017

alexander-akait approved these changes Oct 20, 2017

View reviewed changes

akihikodaki force-pushed the master branch from 426e758 to 52a1942 Compare October 20, 2017 13:34

michael-ciniawsky approved these changes Oct 20, 2017

View reviewed changes

joshwiens approved these changes Oct 20, 2017

View reviewed changes

michael-ciniawsky added pr_action: Rebase and removed pr_action: Review labels Oct 20, 2017

akihikodaki force-pushed the master branch from 52a1942 to 8228819 Compare October 21, 2017 01:33

joshwiens added pr_action: Rework and removed pr_action: Rebase labels Oct 21, 2017

Refer to the entry point instead of the first module for default iden…

f2c3056

…tifier The order of modules can be reordered by optimize-module-order plugins. The intention is to use the entry point as the default identifier, so refer to entries property of the compilation.

akihikodaki force-pushed the master branch from 8228819 to f2c3056 Compare October 21, 2017 02:22

michael-ciniawsky removed the pr_action: Rework label Oct 21, 2017

michael-ciniawsky merged commit d5a1de2 into webpack-contrib:master Oct 21, 2017

michael-ciniawsky changed the title ~~refactor: refer to the entry point instead of the first module (module.identifier)~~ refactor: refer to the entrypoint instead of the first module (module.identifier) Oct 21, 2017

michael-ciniawsky changed the title ~~refactor: refer to the entrypoint instead of the first module (module.identifier)~~ fix: refer to the entrypoint instead of the first module (module.identifier) Oct 21, 2017

michael-ciniawsky removed this from the 3.0.3 milestone Nov 22, 2017

snyk-bot mentioned this pull request Mar 2, 2020

[Snyk] Upgrade extract-text-webpack-plugin from 3.0.0 to 3.0.2 DavidKindler/burger-builder#37

Merged

-                        compilation.modules.forEach((module) => {
-                          if (module.id === id) { item[0] = module.identifier(); }
+                      if (typeof text === 'string') {
+                        text = [[compilation.entries[0].identifier(), text]];

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: refer to the `entrypoint` instead of the first `module` (`module.identifier`) #601

fix: refer to the `entrypoint` instead of the first `module` (`module.identifier`) #601

akihikodaki commented Aug 14, 2017

jsf-clabot commented Aug 14, 2017 •

edited

Loading

codecov bot commented Aug 14, 2017 •

edited

Loading

alexander-akait left a comment

akihikodaki commented Aug 15, 2017

akihikodaki commented Aug 15, 2017

akihikodaki commented Aug 15, 2017

alexander-akait commented Aug 15, 2017

alexander-akait commented Sep 13, 2017

sokra left a comment

sokra Oct 19, 2017

alexander-akait commented Oct 19, 2017

michael-ciniawsky commented Oct 19, 2017 •

edited

Loading

sgal commented Oct 19, 2017

akihikodaki commented Oct 20, 2017

michael-ciniawsky left a comment

joshwiens commented Oct 20, 2017

michael-ciniawsky commented Oct 20, 2017

akihikodaki commented Oct 21, 2017

michael-ciniawsky commented Oct 21, 2017

akihikodaki commented Oct 21, 2017

michael-ciniawsky commented Oct 21, 2017 •

edited

Loading

akihikodaki commented Oct 21, 2017

cletusw commented Oct 21, 2017

sgal commented Oct 25, 2017 •

edited

Loading

fix: refer to the entrypoint instead of the first module (module.identifier) #601

fix: refer to the entrypoint instead of the first module (module.identifier) #601

Conversation

akihikodaki commented Aug 14, 2017

jsf-clabot commented Aug 14, 2017 • edited Loading

codecov bot commented Aug 14, 2017 • edited Loading

Codecov Report

alexander-akait left a comment

Choose a reason for hiding this comment

akihikodaki commented Aug 15, 2017

akihikodaki commented Aug 15, 2017

akihikodaki commented Aug 15, 2017

alexander-akait commented Aug 15, 2017

alexander-akait commented Sep 13, 2017

sokra left a comment

Choose a reason for hiding this comment

sokra Oct 19, 2017

Choose a reason for hiding this comment

alexander-akait commented Oct 19, 2017

michael-ciniawsky commented Oct 19, 2017 • edited Loading

Issues

sgal commented Oct 19, 2017

akihikodaki commented Oct 20, 2017

michael-ciniawsky left a comment

Choose a reason for hiding this comment

joshwiens commented Oct 20, 2017

michael-ciniawsky commented Oct 20, 2017

akihikodaki commented Oct 21, 2017

michael-ciniawsky commented Oct 21, 2017

akihikodaki commented Oct 21, 2017

michael-ciniawsky commented Oct 21, 2017 • edited Loading

akihikodaki commented Oct 21, 2017

cletusw commented Oct 21, 2017

sgal commented Oct 25, 2017 • edited Loading

fix: refer to the `entrypoint` instead of the first `module` (`module.identifier`) #601

fix: refer to the `entrypoint` instead of the first `module` (`module.identifier`) #601

jsf-clabot commented Aug 14, 2017 •

edited

Loading

codecov bot commented Aug 14, 2017 •

edited

Loading

michael-ciniawsky commented Oct 19, 2017 •

edited

Loading

`Issues`

michael-ciniawsky commented Oct 21, 2017 •

edited

Loading

sgal commented Oct 25, 2017 •

edited

Loading