Remove description about module ID 0 #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 as the ID of a module does not tell it is an entry point because the ID can be affected by optimize-module-order plugins.
skipjack
approved these changes
Aug 20, 2017
There was a problem hiding this comment.
This seems valid to me and module IDs can be a affected by a variety of plugins so this example does seem a bit out place. Probably better to use stats/records to determine whether a module is an entry point.
Anyways, via the link, the module.id section should do all the in depth description about itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 as the ID of a module does not tell it is an entry point because the ID can be affected by
optimize-module-orderplugins.