Filename filtering

[lcxfs1991]

change the filename for css

[codecov-io]

Current coverage is 80.82% (diff: 100%)

Merging #269 into webpack-1 will increase coverage by 0.05%

@@           webpack-1       #269   diff @@
===========================================
  Files              4          4          
  Lines            338        339     +1   
  Methods           72         72          
  Messages           0          0          
  Branches          71         72     +1   
===========================================
+ Hits             273        274     +1   
  Misses            65         65          
  Partials           0          0          

Powered by Codecov. Last update 2db50ee...fa1a429

[bebraw]

The idea looks good to me. I'm not sure of the naming so maybe others can comment on that.

Please sign the CLA in any case.

[lcxfs1991]

@bebraw have you also considered this for the plugin for webpack2?

[bebraw]

It's up to Tobias.

I think I would overload filename now rather than having another field. Then you would end up with:

new ExtractTextPlugin(({ name }) => `stylesheets/${name}.css`);
new ExtractTextPlugin({ filename: ({ name }) => `stylesheets/${name}.css` });

That's as flexible as it can get. The same idea would work elsewhere in webpack too if this scheme is acceptable.

[lcxfs1991]

yep. Shall we wait for the scheme, maybe next version of webpack?

[bebraw]

It needs a design decision, yeah.

[bebraw]

@lcxfs1991 Would it be possible for you to refactor the idea to follow the specification I discussed? Instead of a new field we would overload the current filename. That would give us the feature without growing the API.

[lcxfs1991]

@bebraw I have refractor my code and add test cases. Please check.

pull request:
#423

[lcxfs1991]

this one can be closed