-
Notifications
You must be signed in to change notification settings - Fork 512
fix: add a not null check for the content property before throwing error #404
Conversation
Codecov Report
@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 90.42% 90.38% -0.04%
==========================================
Files 6 6
Lines 355 364 +9
Branches 74 77 +3
==========================================
+ Hits 321 329 +8
- Misses 34 35 +1
Continue to review full report at Codecov.
|
Would it be possible to add a test against this case so we don't break it in the future? Good apart from that. |
@bebraw Yea sure, it has been a busy couple weeks...I'll try getting some test this week. |
@bebraw After looking at this a little further, any suggestions on testing this with watch mode running? I looked at the current set of test suites and it looks like they just run a single compilation using webpack. This test would require running watching mode. |
@sresant That's a good point. I would look into webpack core to see how it handles watch mode related tests. If there's no way, let's merge. 👍 |
@bebraw Looking at it the webpack core version of the watchmode test suite is different from what this test would require to work so might be more difficult to implement :( |
@d3viant0ne Any thoughts on this? Small change. |
@michael-ciniawsky Maybe merge? I don't see this breaking anything so might as well. A comment would be good, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sresant Please add a comment in case this causes regressions
@bebraw Yep it should be fine, but I'm not 💯 with ETWP yet tbh 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sresant Thx
@sresant Please close and reopen the PR to trigger the CLA Bot again and sign the CLA :) |
Took this change - build goes green, but in console every second build this error occurs:
|
This check will fix #42 for webpack2 users.