This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix: Modules shouldn't be passed to sort #568

Merged

joshwiens merged 1 commit into feature/webpack3 from d3viant0ne-FixTypeError

Jul 10, 2017

Member

joshwiens commented Jul 10, 2017 •

edited

Loading

module was incorrectly being passed to the sort function with throws a type error in certain circumstances.

Fixes #565
Fixes #554


          fix: Modules shouldn't be passed to sort

f15c7ae

joshwiens added priority: 3 (required) pr_action: Review semver: Patch severity: 2 (regression) type: Bug labels

joshwiens requested review from hulkish, alexander-akait and michael-ciniawsky

July 10, 2017 00:44

michael-ciniawsky approved these changes

View reviewed changes

hulkish approved these changes

View reviewed changes

joshwiens merged commit 113cabb into feature/webpack3

joshwiens deleted the d3viant0ne-FixTypeError branch

July 10, 2017 01:38

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr_action: Review priority: 3 (required) semver: Patch severity: 2 (regression) type: Bug