Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi target for webpack-dev-server task #143

Merged

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Jun 12, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Tests added? no
Docs updated? no
Fixed tickets none
License MIT

This PR is counterpart of #140 which fix multi target for webpack task.

This is a bug when running grunt webpack-dev-server with multi targets. If we define multi targets for this plugin, then only 1 or 2 of them will run when user calls grunt webpack-dev-server, and the tasks are picked randomly.

This is because now the code use a global done for all targets, any of them finished will cause this task done.

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #143 into master will decrease coverage by 1.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   67.67%   66.66%   -1.02%     
==========================================
  Files           8        8              
  Lines         198      201       +3     
  Branches       50       51       +1     
==========================================
  Hits          134      134              
- Misses         52       55       +3     
  Partials       12       12
Impacted Files Coverage Δ
tasks/webpack-dev-server.js 15.55% <0%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7ed27...7caf25d. Read the comment docs.

@danez danez merged commit d224f69 into webpack-contrib:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants