Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better fix for #334 #343

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

RAX7
Copy link
Contributor

@RAX7 RAX7 commented Sep 8, 2022

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Makes possible to use minimizer/generator filename option with unsupported formats or multiple minimizers

Breaking Changes

Implementation should return Promise<null> for unprocessed data now. But worker still returns not nullable Promise<WorkerResult>.

Additional Info

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 87.57% // Head: 87.77% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (f19d8ab) compared to base (667863d).
Patch coverage: 91.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   87.57%   87.77%   +0.19%     
==========================================
  Files           4        4              
  Lines         644      638       -6     
  Branches      242      243       +1     
==========================================
- Hits          564      560       -4     
+ Misses         72       70       -2     
  Partials        8        8              
Impacted Files Coverage Δ
src/utils.js 80.77% <72.72%> (+0.50%) ⬆️
src/worker.js 93.75% <100.00%> (-3.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good solution, thank you

@RAX7 RAX7 mentioned this pull request Sep 9, 2022
6 tasks
@alexander-akait alexander-akait merged commit 78dcac9 into webpack-contrib:master Sep 9, 2022
@RAX7 RAX7 deleted the normalize-result branch September 9, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants