fix: crash when using filesystem cache #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
webdiscus
reviewed
Dec 18, 2024
| ABSOLUTE_URL_REGEX.test(this.resourcePath) && | ||
| !WINDOWS_PATH_REGEX.test(this.resourcePath) | ||
| ? this.resourcePath | ||
| : this.utils.contextify(this.rootContext, this.resourcePath); |
There was a problem hiding this comment.
The filename must be a relative path without leading ./:
- this.utils.contextify(this.rootContext, this.resourcePath) =>
./src/image.svg(❌ wrong filename) - path.relative(this.rootContext, this.resourcePath) =>
src/image.svg(✅ correct filename)
Please, see the details in my updated comment
I have linked the NEW small as possible repo with reproducible issue.
Thank you!
There was a problem hiding this comment.
strange, I'll have a look now
There was a problem hiding this comment.
There was a problem hiding this comment.
Now with tests 😄
There was a problem hiding this comment.
it works now :-)
thank you!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
fixes #458
fixes #459
Breaking Changes
No
Additional Info
Let's refactor to avoid misleading logic, because we need it only for URLs, also let's cache this