Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package): update webpack-dev-middleware v1.12.0...2.0.6 (dependencies) #318

Merged
merged 1 commit into from
Mar 19, 2018
Merged

chore(package): update webpack-dev-middleware v1.12.0...2.0.6 (dependencies) #318

merged 1 commit into from
Mar 19, 2018

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Mar 15, 2018

Fixes #314

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:
    • Update webpack-dev-middleware dependency

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact: the new major release is required since webpack ^1.0.0 support has been dropped in webpack-dev-middleware ^2.0.0

Other information:

@jsf-clabot
Copy link

jsf-clabot commented Mar 15, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title chore(package): update webpack-dev-middleware to ^2.0.6 chore(package): update webpack-dev-middleware v1.12.0...2.0.6 (dependencies) Mar 15, 2018
@michael-ciniawsky
Copy link
Contributor

michael-ciniawsky commented Mar 15, 2018

What's the exact issue you're facing and would #315 fix it? Note that #315 requires webpack >= v4.0.0 && node >= v6.0.0. If that's sufficient I would favor #315 over this PR instead

@limonte
Copy link
Contributor Author

limonte commented Mar 15, 2018

What's the exact issue you're facing and would #315 fix it?

Oh, I didn't notice #315, apologies. Basically, it's the same, but as you said

#315 requires webpack >= v4.0.0

and this PR will still support webpack 2 and 3.

#315 will work for me personally (we're trying to fix flaky sweetalert2/sweetalert2#986) so I'm okay to close this PR in favor of #315

@michael-ciniawsky
Copy link
Contributor

It should eventually be possible to support webpack =< v4.0.0 in #315 aswell, depending on webpack-dev-middleware v2.0.0 <=> v3.0.0 (But I think v3.0.0 is webpack >= v4.0.0 aswell 😭) so maybe we need to majors version bumps then 😒

@limonte
Copy link
Contributor Author

limonte commented Mar 15, 2018

so maybe we need to majors version bumps then

I don't see anything wrong with two major bumps in this case. With proper release titles and release notes, developers will appreciate two different majors for webpack ^2.0.0 - ^4.0.0 projects and webpack ^4.0.0 projects.

@michael-ciniawsky
Copy link
Contributor

michael-ciniawsky commented Mar 19, 2018

Released in v3.0.0 🎉 Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade webpack-dev-middleware dependency
3 participants