Plugins still broken

[bazineta]

See #161.

[jhnns]

Could you create a small test repository with webpack 2 and less-loader 4.x that demonstrates that the less plugin is not installed?

[bazineta]

Sure. Since the test files are so small, if it's all the same to you I'll just attach them here as a zip file.

test.less.zip

Extract to a directory of your choice, npm install, then npm start.

Should result in the 'Plugin.install is not a function' error.

I've used what I believe to be the two most commonly used less plugins for the test case.

[illinar]

Patching package.json entry (see 918bfe9) seems to resolve the problem.

[bazineta]

@illinar Oleg, I think you're referring to the 4.0.0 issue of the package.json referencing a non-existing entry point -- that was corrected in 4.0.1. This issue is in regard to Less plugins not being usable.

[jhnns]

@bazineta thx. clone-deep copies functions, but apparently no properties on the prototype chain (didn't expect this). Since Less plugins are instances of functions/classes, all methods are usually on the prototype instead of the actual instance. That's why our test case is working and actual Less plugins are not. Need to fix that. Thanks for providing a test case.

[jhnns]

Should be fixed with 4.0.2

[bazineta]

LGTM. Thanks!

[sengfan]

Still has the error, Did I make something wrong?
Can anybody help?
Thanks

[sengfan]

it seems it's not compatible with style-loader and to-string-loader?
It works with prod mode, but in dev mode, which fallback to "style-loader", it will show Plugin.install is not a function
{ test: /\.less$/, use: ExtractTextPlugin.extract({ fallback: 'style-loader', use: [ 'css-loader', { loader: 'less-loader', options: { plugins: [ lessPluginAutoPrefix, lessPluginCleanCSS ] } } ] }), include: [helpers.root('src/assets/less')] }

Did I miss something?

[jhnns]

@sengfan please provide a small example repository. This makes tracking down the problem so much easier for me.

[robgietema]

@jhnns I have the same issue as @sengfan , here's my repo where it occurs: https://github.com/plone/plone-react/tree/semantic-ui

[MarkJPerry]

I have an issue where the Plugins are not being run at all. I am using semantic-ui and need to re-write the import statements using less-plugin-rewrite-import and it never runs the plugin code at all.

[riarheos]

I also stumbled upon this problem and found a workaround (but cannot find a good solution though).

The problem comes from including plain css from the less-file with any plugin enabled. Replacing
@import "./reset.css";
with
@import "./reset.less";
worked for me. Hope this somehow helps with the error tracking.

The reproducible small-repo is attached.
less-loader-bug.zip