-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve @import
with absolute paths
#201
fix: resolve @import
with absolute paths
#201
Conversation
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 7 7
Lines 97 97
Branches 8 9 +1
=======================================
Hits 95 95
Misses 2 2
Continue to review full report at Codecov.
|
@import
with absolute paths
Fixes #93 |
@n1ru4l Please add a test for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test.
I wonder if it would be better to fix loaderUtils.urlToRequest
call (possible?). That would push complexity elsewhere, though. See https://github.com/webpack/loader-utils/blob/master/lib/urlToRequest.js .
@n1ru4l Yeah, I think it would take some refactoring (extracting class?) to test this. But it's worth doing to avoid breaking the feature in the future. |
@bebraw I will try that! |
@bebraw I added a test that does not require any refactoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good!
No description provided.