-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't work with css-modules #519
Comments
Please create reproducible test repo |
reproduce: https://github.com/TotooriaHyperion/mini-css-extract-plugin-bug |
Looks like we need a similar behavior like webpack-contrib/style-loader#298 If the locals didn't change, then it shouldn't require a full reload. |
It is not a bug, it is feature, css-modules doesn't support HMR |
replacing the loader of |
Fixed |
Expected Behavior
Should work with css-module
Actual Behavior
If any css file includes a css-module export, then the HMR breaks.
a.css
b.css
Those style without css-module will work. scss file is the same behaviour with css.
Code
How Do We Reproduce?
just add css-modules into the advanced example shown in readme.md.
Then those css/scss file with a :local() in it will fail to hot reload.
Those css/scss file without any :local() works fine.
The text was updated successfully, but these errors were encountered: