fix: error message from sass (#1231)

webpack-contrib · Sep 20, 2024 · c75c606 · c75c606
1 parent ce1ffc7
commit c75c606
Show file tree

Hide file tree

Showing 8 changed files with 433 additions and 94 deletions.
diff --git a/src/utils.js b/src/utils.js
@@ -889,14 +889,15 @@ function errorFactory(error) {
   let message;
 
   if (error.formatted) {
-    message = error.formatted.replace(/^Error: /, "");
+    message = error.formatted.replace(/^(.+)?Error: /, "");
   } else {
     // Keep original error if `sassError.formatted` is unavailable
-    ({ message } = error);
+    message = (error.message || error.toString()).replace(/^(.+)?Error: /, "");
   }
 
   const obj = new Error(message, { cause: error });
 
+  obj.name = error.name;
   obj.stack = null;
 
   return obj;

diff --git a/test/__snapshots__/loader.test.js.no-node-sass.snap b/test/__snapshots__/loader.test.js.no-node-sass.snap
diff --git a/test/__snapshots__/loader.test.js.snap b/test/__snapshots__/loader.test.js.snap
diff --git a/test/__snapshots__/sassOptions-option.test.js.no-node-sass.snap b/test/__snapshots__/sassOptions-option.test.js.no-node-sass.snap
@@ -1224,6 +1224,78 @@ exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'mo
 
 exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
 
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
 exports[`sassOptions option should respect the "outputStyle"/"style" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
 "@charset "UTF-8";
 @import "./file.css";
@@ -4388,6 +4460,78 @@ exports[`sassOptions option should work with custom scheme import ('sass-embedde
 
 exports[`sassOptions option should work with custom scheme import ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
 
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
 exports[`sassOptions option should work with the "functions" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
 "h2, h3, h4, h5 {
   color: #08c;

diff --git a/test/__snapshots__/sassOptions-option.test.js.snap b/test/__snapshots__/sassOptions-option.test.js.snap
@@ -1404,6 +1404,78 @@ exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'mo
 
 exports[`sassOptions option should ignore the "url" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
 
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+method not found: 'get$iterator' (J.getInterceptor$ax(...).get$iterator is not a function)",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+arr.flatMap is not a function",
+]
+`;
+
+exports[`sassOptions option should output a normal error with the wrong "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
 exports[`sassOptions option should respect the "outputStyle"/"style" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
 "@charset "UTF-8";
 @import "./file.css";
@@ -5054,6 +5126,78 @@ exports[`sassOptions option should work with custom scheme import ('sass-embedde
 
 exports[`sassOptions option should work with custom scheme import ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
 
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('dart-sass', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern' API, 'scss' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'sass' syntax): warnings 1`] = `[]`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): errors 1`] = `
+[
+  "ModuleBuildError: Module build failed (from ../src/cjs.js):
+Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.",
+]
+`;
+
+exports[`sassOptions option should work with the "fatalDeprecations" option ('sass-embedded', 'modern-compiler' API, 'scss' syntax): warnings 1`] = `[]`;
+
 exports[`sassOptions option should work with the "functions" option ('dart-sass', 'legacy' API, 'sass' syntax): css 1`] = `
 "h2, h3, h4, h5 {
   color: #08c;

diff --git a/test/sass/slash-div.sass b/test/sass/slash-div.sass
@@ -0,0 +1,5 @@
+.example
+  color: red
+
+  a
+    font-weight: (4/2)
diff --git a/test/sassOptions-option.test.js b/test/sassOptions-option.test.js
@@ -524,6 +524,44 @@ describe("sassOptions option", () => {
 
         await close(compiler);
       });
+
+      if (isModernAPI) {
+        it(`should output a normal error with the wrong "fatalDeprecations" option ('${implementationName}', '${api}' API, '${syntax}' syntax)`, async () => {
+          const testId = getTestId("language", syntax);
+          const options = {
+            implementation,
+            api,
+            sassOptions: {
+              fatalDeprecations: "test",
+            },
+          };
+          const compiler = getCompiler(testId, { loader: { options } });
+          const stats = await compile(compiler);
+
+          expect(getWarnings(stats)).toMatchSnapshot("warnings");
+          expect(getErrors(stats)).toMatchSnapshot("errors");
+
+          await close(compiler);
+        });
+
+        it(`should work with the "fatalDeprecations" option ('${implementationName}', '${api}' API, '${syntax}' syntax)`, async () => {
+          const testId = getTestId("slash-div", syntax);
+          const options = {
+            implementation,
+            api,
+            sassOptions: {
+              fatalDeprecations: ["slash-div"],
+            },
+          };
+          const compiler = getCompiler(testId, { loader: { options } });
+          const stats = await compile(compiler);
+
+          expect(getWarnings(stats)).toMatchSnapshot("warnings");
+          expect(getErrors(stats)).toMatchSnapshot("errors");
+
+          await close(compiler);
+        });
+      }
     });
   });
 });
diff --git a/test/scss/slash-div.scss b/test/scss/slash-div.scss
@@ -0,0 +1,7 @@
+.example {
+  color: red;
+
+  a {
+    font-weight: (4/2);
+  }
+}