pathUtils | fix memory leak

[Galcarmi]

Closes #414

[linux-foundation-easycla]

• ❌ - login: @Galcarmi / name: Gal carmi . The commit (86fd6ca, 6b55c49, 0d6d26b, b7dcd3e) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[alexander-akait]

I don't think we need this big package here, you can rewrite this package and put it inside project, because we use only the max value

[Galcarmi]

i'll implement it and update

[alexander-akait]

Let's use your implementation here and remove this package from here

[alexander-akait]

Also there is simple and fast example:

class LRU {
    constructor(max = 2048) {
        this.max = max;
        this.cache = new Map();
    }

    get(key) {
        let item = this.cache.get(key);
        if (item !== undefined) {
            // refresh key
            this.cache.delete(key);
            this.cache.set(key, item);
        }
        return item;
    }

    set(key, val) {
        // refresh key
        if (this.cache.has(key)) this.cache.delete(key);
        // evict oldest
        else if (this.cache.size === this.max) this.cache.delete(this.first());
        this.cache.set(key, val);
    }

    first() {
        return this.cache.keys().next().value;
    }
}

[alexander-akait]

@vankop What do you think about it? Yeah, we have a memory leak here, if you run develpment your application very long our cache will be bigger and bigger, so I think using lru cache is good idea, but I don't know what is will be better number for max

[vankop]

I personally think we dont need cache here.. maybe at first implementation there was some specific usage for resolver.join, but right now it used in a lot of cases, sometimes even on each plugin call. ( see JoinPlugins ) So probably cache hit is very low. basically happen only on the same resolving, this happens quite rarely on incremental builds

[vankop]

on cold builds it does not make sense either since very low cache hit

[Galcarmi]

@alexander-akait sorry I'm a bit busy, I'll address it at the weekend,

@vankop so do you recommend to just remove it instead?

[alexander-akait]

@vankop Can you test it on some repo and check it?

[vankop]

we have a metrics repo, we just need to setup cache hits there...