Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript definitions #70

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix typescript definitions

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files           5        5           
  Lines         568      568           
  Branches      255      255           
=======================================
  Hits          560      560           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b98e06c...28f5fd8. Read the comment docs.

@alexander-akait alexander-akait merged commit f38158d into master Oct 15, 2019
@alexander-akait alexander-akait deleted the fix-typescript-definitions branch October 15, 2019 15:44
@vankop
Copy link
Member

vankop commented Oct 17, 2019

@evilebottnawi do you mind to PR this fix in ajv?

@alexander-akait
Copy link
Member Author

@vankop no need, we add children property in our code so we should provide other type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants