refactor: move watching message to WebpackCLIPlugin

webpack · Oct 22, 2020 · 793b444 · 793b444
1 parent fd846e2
commit 793b444
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/packages/webpack-cli/lib/plugins/WebpackCLIPlugin.js b/packages/webpack-cli/lib/plugins/WebpackCLIPlugin.js
@@ -35,8 +35,15 @@ class WebpackCLIPlugin {
 
             logger.success(`Compilation${compilation.name ? `${compilation.name}` : ''} starting...`);
         });
+
         compiler.hooks.done.tap(PluginName, (compilation) => {
             logger.success(`Compilation${compilation.name ? `${compilation.name}` : ''} finished`);
+
+            process.nextTick(() => {
+                if (compiler.watchMode) {
+                    logger.success('watching files for updates...');
+                }
+            });
         });
     }
 }

diff --git a/packages/webpack-cli/lib/webpack-cli.js b/packages/webpack-cli/lib/webpack-cli.js
@@ -250,17 +250,10 @@ class WebpackCLI extends GroupHelper {
         await this.processArgs(args, cliOptions);
 
         let compiler;
+
         let options = this.compilerConfiguration;
         let outputOptions = this.outputConfiguration;
 
-        let isWatchMode;
-
-        if (Array.isArray(options)) {
-            isWatchMode = options.some((options) => options.watch);
-        } else {
-            isWatchMode = options.watch;
-        }
-
         const isRawOutput = typeof outputOptions.json === 'undefined';
 
         if (isRawOutput) {
@@ -327,10 +320,6 @@ class WebpackCLI extends GroupHelper {
             } else {
                 logger.raw(`${stats.toString(foundStats)}`);
             }
-
-            if (isWatchMode) {
-                logger.success('watching files for updates...');
-            }
         };
 
         compiler = this.createCompiler(options, callback);