Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export utils from core for other packages #2011

Merged
merged 5 commits into from
Nov 2, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary
Exported some utils which are used by other packages so we won't depend on the file structure as it can change in core hence it will break other packages.

Does this PR introduce a breaking change?
No

Other information
NA

@anshumanv anshumanv changed the title feat: export utils from core used by other packages feat: export utils from core for other packages Nov 1, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove template?

@anshumanv
Copy link
Member Author

which template @evilebottnawi ?

@anshumanv anshumanv marked this pull request as ready for review November 2, 2020 11:08
@anshumanv anshumanv requested a review from a team as a code owner November 2, 2020 11:08
@alexander-akait
Copy link
Member

From the PR 😄

// export additional utils used by other packages
module.exports.logger = logger;
module.exports.commands = commands;
module.exports.getPackageManager = getPackageManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's export this under util, like webpackCli.util.logger?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do small improvement

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@anshumanv anshumanv merged commit 3004549 into webpack:master Nov 2, 2020
@anshumanv anshumanv deleted the feat/utils-export branch November 2, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants