tests: add a case for invalid context value #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
commented
Nov 3, 2020
snitin315
force-pushed
the
tests/context
branch
from
4132bae to
9b3c4c5
Compare
|
fixed for windows. |
alexander-akait
approved these changes
Nov 4, 2020
|
/cc @webpack/cli-team |
anshumanv
reviewed
Nov 4, 2020
|
Mostly we are using general tests for example for We have specific test cases only for a few options like |
|
That makes sense, let's cover others too then |
|
Will we do it in another PR? |
|
Yes, I will check and snatch them all in future PR. |
|
Sure let's merge this one then |
anshumanv
approved these changes
Nov 4, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
tests
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
NA
Summary
add a case for invalid context value
Does this PR introduce a breaking change?
No
Other information
No