Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to force start finish log #2566

Merged
merged 4 commits into from
Mar 28, 2021
Merged

feat: add flag to force start finish log #2566

merged 4 commits into from
Mar 28, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
wip

If relevant, did you update the documentation?
NA

Summary
Add a env var to force compilation log

Does this PR introduce a breaking change?
No

Other information

alexander-akait
alexander-akait reviewed Mar 27, 2021
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For watch too

@codecov
Copy link

codecov bot commented Mar 27, 2021 •
edited
Loading

Codecov Report

Merging #2566 (cfccfa9) into master (a8afb64) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2566      +/-   ##
==========================================
+ Coverage   91.12%   91.14%   +0.02%     
==========================================
  Files          29       29              
  Lines        1464     1468       +4     
  Branches      420      421       +1     
==========================================
+ Hits         1334     1338       +4     
  Misses        130      130
Impacted Files Coverage Δ
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8afb64...cfccfa9. Read the comment docs.

@anshumanv anshumanv changed the title feat[wip]: add flag to force start finish log feat: add flag to force start finish log Mar 27, 2021
@anshumanv anshumanv marked this pull request as ready for review March 27, 2021 15:49
@anshumanv anshumanv requested a review from a team as a code owner March 27, 2021 15:49
@anshumanv
Copy link
Member Author

@alexander-akait ready

@anshumanv
Copy link
Member Author

@webpack/cli-team

@anshumanv anshumanv merged commit 281aad3 into master Mar 28, 2021
@anshumanv anshumanv deleted the force-log branch March 28, 2021 06:31
@alexander-akait
Copy link
Member

Need docs

@alexander-akait alexander-akait mentioned this pull request Mar 29, 2021
Closed
@anshumanv
Copy link
Member Author

will add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anshumanv @alexander-akait @snitin315 @webpack-bot