Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use memory-fs when writeToDisk is true #1537

Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 3, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Don't use memory-fs when writeToDisk is true, because it doesn't make sense to write in memory and on disk, due to this some plugins like option.clean (we use a plugin under the hood) and other can be broken

partial #861

Breaking Changes

theoretically it can break some exotic cases when you use non public things, but should not

Additional Info

No

@alexander-akait alexander-akait merged commit 852245e into master May 3, 2023
@alexander-akait alexander-akait deleted the fix-compatibility-with-clean-plugin-for-writeToDisk branch May 3, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant