-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(contributing): alternative way to test #1506
Conversation
CONTRIBUTING.md
Outdated
|
||
```json | ||
"webpack-dev-server": "github:webpack/webpack-dev-server#pull/<ID>/head" | ||
``` | ||
|
||
`<ID>` is the ID of the pull request. | ||
OR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add docs for npm/yarn link
usage here instead? You can keep "webpack-dev-server": "file:../path/to/local/webapck-dev-server/fork"
if you like, but please incoporate it into the first example as an alternative value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could update the it with link
but I'd prefer to do it with another PR, if it's ok
Codecov Report
@@ Coverage Diff @@
## master #1506 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 9 9
Lines 590 590
Branches 176 176
=======================================
Hits 517 517
Misses 61 61
Partials 12 12 Continue to review full report at Codecov.
|
PR updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @ematipico friendly ping, sorry for delay, can you rebase? |
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Propose a different way to test the local fork without the need to push to github. I use this way then I want to install deps that live in my local machine
Breaking Changes
N/A
Additional Info