Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): alternative way to test #1506

Merged
merged 3 commits into from
Apr 9, 2019

Conversation

ematipico
Copy link
Contributor

  • This is a bugfix
  • This is a code refactor
  • This is a test update
  • This is a typo fix
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Propose a different way to test the local fork without the need to push to github. I use this way then I want to install deps that live in my local machine

Breaking Changes

N/A

Additional Info

CONTRIBUTING.md Outdated

```json
"webpack-dev-server": "github:webpack/webpack-dev-server#pull/<ID>/head"
```

`<ID>` is the ID of the pull request.
OR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add docs for npm/yarn link usage here instead? You can keep "webpack-dev-server": "file:../path/to/local/webapck-dev-server/fork" if you like, but please incoporate it into the first example as an alternative value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could update the it with link but I'd prefer to do it with another PR, if it's ok

@michael-ciniawsky michael-ciniawsky added this to the 3.1.9 milestone Sep 17, 2018
@michael-ciniawsky michael-ciniawsky changed the title docs(contribution): alternative way to test docs(contributing): alternative way to test Sep 17, 2018
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #1506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1506   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files           9        9           
  Lines         590      590           
  Branches      176      176           
=======================================
  Hits          517      517           
  Misses         61       61           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e8db0...24166bb. Read the comment docs.

@ematipico
Copy link
Contributor Author

PR updated!

Copy link

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-akait
Copy link
Member

/cc @ematipico friendly ping, sorry for delay, can you rebase?

@ematipico ematipico closed this Apr 9, 2019
@ematipico ematipico reopened this Apr 9, 2019
@ematipico ematipico requested a review from hiroppy as a code owner April 9, 2019 08:05
@alexander-akait alexander-akait merged commit f5ea174 into webpack:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants