-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): allow sock host to use browser location's host #2859
Conversation
I'll sign the CLA soon. Just sent it to my company's legal team to review. |
Codecov Report
@@ Coverage Diff @@
## master #2859 +/- ##
==========================================
- Coverage 93.77% 93.55% -0.22%
==========================================
Files 34 34
Lines 1333 1335 +2
Branches 381 382 +1
==========================================
- Hits 1250 1249 -1
- Misses 81 84 +3
Partials 2 2
Continue to review full report at Codecov.
|
It just occurred to me that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is use case?
I believe you can set the host to |
Thanks to you both for taking a look so quickly! @jsg2021 I did notice the conditional that sets hostname to loc.host if it's @alexander-akait I'm trying to support local and remote development for my team a bit better. The app/framework I'm using allows developers to create publicly accessible URLs that expose services running within a container. (Ex: The problem is that wds always tries to connect to Setting |
Can you switch on v4 branch? Only security fixes for v3 (if it is possible) |
Certainly. Although I'm not confident in this implementation anymore since we'd cause unexpected behavior for users that actually want to set their host to I'll think about this for a bit and open a different PR against the |
@gluxon I meant on the client include entry point:
this won't effect the server binding |
@jsg2021 Ah I misunderstood. That's a good workaround for I noticed that using |
For Bugs and Features; did you add new tests?
Yes!
Motivation / Use-Case
This is templated off of commit 0835a19/#2341, but for the browser location's hostname instead of its port.
This is useful when webpack-dev-server is being accessed behind a reverse proxy with a hostname that's not known at build time.
Breaking Changes
No breaking changes.
Additional Info
None