Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commons-chunk-plugin.md #1925

Closed
wants to merge 2 commits into from
Closed

Conversation

vuhuucuong
Copy link

@vuhuucuong vuhuucuong commented Mar 18, 2018

From https://gist.github.com/sokra/1522d586b8e5c0f5072d7565c2bee693

describe your changes...

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Remove these instructions from your PR as they are for your eyes only.

@jsf-clabot
Copy link

jsf-clabot commented Mar 18, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Member

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change base branch to next.

@jeremenichelli
Copy link
Member

@kencoder97 thanks for the contribution, but we are thinking on adding just a warning on the common chunks page and creating a separate page for split chinks one. Would you mind taking a look at it to see if some of your content might be missing there? #1955

Thanks again.

@EugeneHlushko
Copy link
Member

@jeremenichelli @montogeek i think this should be closed now via #1955 ?

@EugeneHlushko
Copy link
Member

closing via #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants