Added GitHub token for authenticated GitHub API calls #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the problem was that we were fetching even when no token was present? We'll still gonna fetch on Travis I guess, I don't know if this will actually solve our quota issue. |
|
No, we weren't using auth at all, this add authentication if the token exists (on Travis CI), a contributor won't have it locally, so I added a check before using it |
jeremenichelli
approved these changes
Mar 27, 2018
|
Go for it! |
|
great addition! |
This was referenced Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting GH Rate limit (60 request/hr) very quickly, this will increase it to 5000.