Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(config): add contentBasePublicPath option #3525

Merged
merged 1 commit into from
Feb 11, 2020
Merged

docs(config): add contentBasePublicPath option #3525

merged 1 commit into from
Feb 11, 2020

Conversation

G100g
Copy link
Contributor

@G100g G100g commented Feb 7, 2020

Add contentBasePublicPath option description in dev-server configuration section.

https://webpack.js.org/configuration/dev-server/

@G100g G100g mentioned this pull request Feb 7, 2020
Closed
1 task
wizardofhogwarts
wizardofhogwarts approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@montogeek montogeek merged commit 4be2137 into webpack:master Feb 11, 2020
@montogeek
Copy link
Member

Thanks!

@G100g G100g deleted the issues/3524 branch February 12, 2020 12:01
@iamandrewluca
Copy link
Contributor

iamandrewluca commented Feb 12, 2020 •
edited
Loading

Why the original PR was ignored? It was identical duplicated. Sad. 😕
I rebased on top of master and fixed the example.

#3291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizardofhogwarts wizardofhogwarts wizardofhogwarts approved these changes

@anikethsaha anikethsaha anikethsaha approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@jeffin143 jeffin143 jeffin143 approved these changes

@anshumanv anshumanv anshumanv approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@montogeek montogeek montogeek approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@G100g @montogeek @iamandrewluca @rishabh3112 @anshumanv @jeffin143 @jamesgeorge007 @anikethsaha @wizardofhogwarts