Merge pull request #8573 from hulkish/fix-minimizer-fn

fix when minimizer is fn
webpack · Dec 29, 2018 · 69dea22 · 69dea22
2 parents 983c261 + 6240cf6
commit 69dea22
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/lib/WebpackOptionsApply.js b/lib/WebpackOptionsApply.js
@@ -463,7 +463,7 @@ class WebpackOptionsApply extends OptionsApply {
 		if (options.optimization.minimize) {
 			for (const minimizer of options.optimization.minimizer) {
 				if (typeof minimizer === "function") {
-					minimizer.apply(compiler);
+					minimizer.call(compiler, compiler);
 				} else {
 					minimizer.apply(compiler);
 				}

diff --git a/test/configCases/optimization/minimizer/index.js b/test/configCases/optimization/minimizer/index.js
@@ -0,0 +1 @@
+it("should compile", () => {})
diff --git a/test/configCases/optimization/minimizer/webpack.config.js b/test/configCases/optimization/minimizer/webpack.config.js
@@ -0,0 +1,18 @@
+const Compiler = require('../../../../lib/Compiler');
+
+module.exports = {
+	optimization: {
+		minimize: true,
+		minimizer: [
+			{
+				apply(compiler) {
+					expect(compiler).toBeInstanceOf(Compiler);
+				},
+			},
+			function(compiler) {
+				expect(compiler).toBe(this);
+				expect(compiler).toBeInstanceOf(Compiler);
+			}
+		],
+	},
+};