Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine webpack 3 PRs #4770

Closed
wants to merge 15 commits into from
Closed

Combine webpack 3 PRs #4770

wants to merge 15 commits into from
+746 −643

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 23, 2017 •
edited
Loading

What kind of change does this PR introduce?
PR combine

Does this PR introduce a breaking change?
yes

PRs
#4764
#4738
#4704
#4144
#4143

origin/bugfix/status
origin/fix/node_modules_mangle
origin/bugfix/child-records-cache
origin/perf/modules-set
origin/perf/chunks-set

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@tleunen
Copy link

tleunen commented Apr 24, 2017

Got this warning during the build:

(node:84752) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.

@sokra
Copy link
Member Author

sokra commented Apr 25, 2017

You can use node --trace-deprecation to find the origin.

sokra added 7 commits May 4, 2017 13:05
@sokra
assign correct records and cache to child compilations
101850c 
This is a breaking change because plugins or loader could rely on this incorrect behavior
When using child compilations plugins and loaders should use a unique compiler name or use a consistent order

fixes #2777
@sokra
fixes incorrect CLI stats output
206ef6d 
add "detailed" preset
clean up presets to do more useful stuff

fixes #4141
fixes #4118
@sokra
Merge remote-tracking branch 'origin/bugfix/status' into beta
f24ce86
@sokra
Merge remote-tracking branch 'origin/fix/node_modules_mangle' into beta
bff6d71
@sokra
Merge remote-tracking branch 'origin/bugfix/child-records-cache' into…
8e85452 
… beta
@sokra
Merge remote-tracking branch 'origin/perf/modules-set' into beta
d3ce67c
@sokra
Merge remote-tracking branch 'origin/perf/chunks-set' into beta
4042885
@evan-scott-zocdoc
Copy link

Out of curiosity, what level of speed improvement are you seeing with these changes?

@sokra sokra closed this May 28, 2017
@sokra sokra deleted the beta branch July 12, 2017 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: CI-ok PR: unreviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sokra @webpack-bot @tleunen @evan-scott-zocdoc