fix truncated JSON output with JSON reporter #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @refractalize! I'm willing to just merge it, unless you have a simple/performant way to test this? |
Nothing that comes to mind. We could get some tests around it perhaps if we extract a function that writes output, and test that in isolation, but yeah, it'd be launching a new executable that writes a lot of stdout then exits immediately afterwards, not that elegant. What I might do is just add a comment with a link referring to the known issue in node.js. |
|
Thanks @refractalize! |
|
🚀 This pull request is included in v5.0.2. See Release 5.0.2 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello - I noticed that when using
--reporter=jsonon a project with a lot of unused code the JSON output was truncated. This seems to be due to this known issue, a combination of large output (> 65k) followed byprocess.exit(). See this issue: nodejs/node#6379.I've applied the workaround documented in that (and related) issues.
Let me know if you think I should write a test for it.