jest: support custom testEnvironment #834
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
tryggvigy
force-pushed
the
harden-jest-test-environment
branch
from
021d2c5 to
839f679
Compare
I think it's because of a previous build, you can run |
webpro
reviewed
Nov 13, 2024
| environments = ['jest-environment-jsdom']; | ||
| } else if (config.testEnvironment) { | ||
| environments = [config.testEnvironment]; | ||
| } |
There was a problem hiding this comment.
Maybe we could make it a const in one line? That's become a bit of a standard whenever possible, for consistency.
There was a problem hiding this comment.
It would require a nested ternary but I can do that!
|
Thanks @tryggvigy! Nested ternaries aren't marvellous, but heck. |
|
🚀 This pull request is included in v5.37.0. See Release 5.37.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds support for custom
testEnvironmentfiles like:I get a unit test failure on the cli version when running the tests locally. Maybe it'll pass in CI. Anyone know how to fix that?
