Update App Branding #227
Merged
Update App Branding #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Puts download links at the top of the Readme - Minor updates to build instructions
Seems to be unused
HACK: The main app logo is currently composed of the graphic component returned by ReplayWeb.page which is then assigned a different variable in ArchiveWeb.page with `get mainLogo`. The text is then appended by ArchiveWeb.page. Because the text and icon are now located in the same file for both apps, this behavior is worth cleaning up once both are up to date and using TypeScript. For now, this returns nothing as the `mainLogo` value and appends the whole new logo lockup instead of just the text.
- Replaces with FontAwesome's cloud upload equivalent - Also removes unused `webrecorder-text` SVG
- Adds checkmark on idle
ikreymer
reviewed
Sep 19, 2024
| get mainLogo() { | ||
| return wrLogo; |
There was a problem hiding this comment.
yeah, this is probably something we can cleanup as part of AWP typescript conversion, this is probably best option for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/src/assetsto match ReplayWebpage & Browsertrix project file structure/buildand/src/staticScreenshots
New vs Current Extension Icon
New Lockup
New status icon in the Electron app
Caveats
~assetslike Browsertrix and ReplayWeb.page (because obviously this isn't TypeScript yet!) Would be a nice thing to clean up with the TypeScript conversion later to have the same conventions across all our projects.get mainLogo. The text is then appended by ArchiveWeb.page.mainLogovalue and appends the whole new logo lockup instead of just the text.