Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewriting fix: twitter video in embedded tweets #761

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Sep 1, 2022

Description

Improve twitter rewrite to also use mp4 for videos in twitter embed

Motivation and Context

Partial fix to embedded tweets, as described in webrecorder/browsertrix-crawler#160

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer ikreymer merged commit 8ef4ff1 into main Sep 1, 2022
@ikreymer ikreymer deleted the twitter-embed-video-optimize branch September 1, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant