Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fontawesome icon for timeline zoom out, remove unused static files #895

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Apr 4, 2024

Fixes #876

Description

This fixes a problem where the path to a zoom out icon was hardcoded to /static by replacing that icon entirely with a fontawesome icon, consistent with the other icons in the Vue header.

Additionally, a few unused static images that are not being used in the app are removed.

Screenshots (if appropriate):

New fontawesome icon:

Screen Shot 2024-04-04 at 2 00 08 PM

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l requested a review from ikreymer April 4, 2024 18:07
@tw4l
Copy link
Member Author

tw4l commented Apr 4, 2024

One more quick patch release change for you to review, @ikreymer :)

@tw4l tw4l merged commit fee14d7 into main Apr 17, 2024
10 checks passed
@tw4l tw4l deleted the issue-876-zoom-icon-static-prefix branch April 17, 2024 04:48
@Quirinus
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL of the zoom image in VueUI not using static_prefix
2 participants