Unify assert_eq!(…)/assert_ne!(…) to take args in order of …!(actual, expected)

[regexident]

While there isn't an explicit convention for this in Rust the stdlib docs all use assert_eq!(actual, expected)/assert_ne!(actual, expected) —as do the Rust by Example and The Rust Programming Language ^(*) books— making it a sort of implicit convention.

The project contains over 2000 occurrences of the pattern /assert_(ne|eq|ok|err)!/, so this PR is clearly a best-effort attempt to unify the arg order. There are no doubt instances that I missed either due to inattentiveness after having gone through thousands of lines of code, or ambiguous argument names.

[algesten]

I personally don't care much about the argument order of asserts, but I'm happy to have cleaner code. Let's merge it! :)

[regexident]

Definitely not a must-have, but a consistent arg ordering makes debugging test failures easier in my experience by not having first figure out which is which.

[codecov]

Codecov Report

Base: 59.86% // Head: 61.09% // Increases project coverage by +1.22% 🎉

Coverage data is based on head (6686933) compared to base (a1492d1).
Patch coverage: 67.30% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   59.86%   61.09%   +1.22%     
==========================================
  Files         504      537      +33     
  Lines       48000    49624    +1624     
  Branches    12503    12594      +91     
==========================================
+ Hits        28736    30318    +1582     
+ Misses      10024     9978      -46     
- Partials     9240     9328      +88     

Impacted Files	Coverage Δ
data/src/data_channel/data_channel_test.rs	59.49% <0.00%> (ø)
dtls/src/crypto/crypto_test.rs	68.18% <ø> (ø)
ice/src/agent/agent_test.rs	66.19% <0.00%> (ø)
.../src/external_ip_mapper/external_ip_mapper_test.rs	50.61% <0.00%> (ø)
ice/src/mdns/mdns_test.rs	69.52% <0.00%> (ø)
ice/src/network_type/network_type_test.rs	77.96% <0.00%> (ø)
ice/src/priority/priority_test.rs	57.69% <0.00%> (ø)
ice/src/state/state_test.rs	92.85% <ø> (ø)
ice/src/tcp_type/tcp_type_test.rs	27.27% <0.00%> (ø)
ice/src/url/url_test.rs	80.70% <0.00%> (ø)
... and 135 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.