allow image media type and udptl protocol in sdp parser #497
Conversation
| @@ -1231,7 +1233,7 @@ fn unmarshal_media_description<'a, R: io::BufRead + io::Seek>( | |||
| let i = index_of( | |||
| proto, | |||
| &[ | |||
| "UDP", "RTP", "AVP", "SAVP", "SAVPF", "TLS", "DTLS", "SCTP", "AVPF", | |||
| "UDP", "RTP", "AVP", "SAVP", "SAVPF", "TLS", "DTLS", "SCTP", "AVPF", "udptl" | |||
There was a problem hiding this comment.
Shouldn’t it be “UDPTL”? https://datatracker.ietf.org/doc/html/rfc7345#section-7
There was a problem hiding this comment.
Hi, your link refers to UDPTL over DTLS, which is something different (and something I've never seen in the wild).
Every implementation I have ever encountered used lowercase "udptl", which seems to be confirmed here: https://www.rfc-editor.org/rfc/rfc5347.html#section-2.5.2
The RFC however seems to recommend matching case-insensitive. Like I said, I have never seen anything other than "udptl" in lowercase, so I'll let you decide what you prefer.
There was a problem hiding this comment.
Got it.
Please fix clippy/fmt error.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 61.56% 61.49% -0.07%
==========================================
Files 529 529
Lines 48839 48839
Branches 12361 12355 -6
==========================================
- Hits 30066 30035 -31
- Misses 9601 9620 +19
- Partials 9172 9184 +12
☔ View full report in Codecov by Sentry. |
No description provided.