AV1: Correctly parse 5-byte leb128 size value #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of leb128 size value a 2-pass approach rather than following the pseudocode in the AV1 spec, presumably for performance reasons. However while the maximum permitted value is indeed 32 bits, the input bytes accumulated in a
u32
are packed 7 bits per byte, thus losing relevant bits from the first byte for 5-byte values. (I believe the leb128 value can be up to 8 bytes with leading zeroes but perhaps that case was fine).I imagine this doesn't come up where the the only large OBU in a binary presented to webrtc-rs has the size omitted, we hit this with an encoder which sets the size on every OBU.