site_url() Should be home_url() in Some Cases

[jaswrks]

Throughout s2Member's source code there are references to site_url() when really this should be home_url() for the best compatibility with sites that run WP from a sub-directory. Much progress on this issue was made awhile back, but there are still a few references that use site_url(). We should take a closer look at the codebase overall and correct this once and for all.

Here is one example where it should really be home_url() to improve compatibility.

[jaswrks]

Next release changelog:

• Several instances of site_url() (a WordPress core function) have been converted to home_url() instead. This provides better compatibility with WordPress installations running from a sub-directory. Please see this GitHub issue if you'd like further details.