Remote Operation get_user on Numeric Usernames

[jaswrks]

Referencing this line of code in s2Member Pro.

If a remote API call is made to find a user by user_login, and that username is_numeric(), the WP_User class will treat it like a user ID instead of as an actual username.

Solution: Use new WP_User(0, [user login]) as the second argument to the constructor. Thereby forcing WP_User to consider it a username, even if it is all numeric.

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Remote Operations API (Bug Fix): If a remote API call was made to find a user by user_login, and that username was all numeric, the WP_User class treated it like a user ID instead of as an actual username. Resolved in this release by calling new WP_User(0, [user login]) as the second argument to the constructor. Thereby forcing WP_User to consider it a username. See also this GitHub issue if you'd like technical details.