Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift code(s) purchased as guest show new codes every time page is refreshed #512

Closed
mfritzsche opened this issue Mar 6, 2015 · 7 comments
Assignees
Milestone

Comments

@mfritzsche
Copy link

I have tested the gift code purchase as a guest (not logged in) and the url that is sent to the email address used in the purchase does in fact take me to the page with the gift code(s) and I can successfully redeem the code when signing up as a member. However, if I visit the url in the email I received when I purchased the gift code(s), new code(s) are shown and refreshing the page will generate new codes every time. These new gift codes can be used when creating a new membership.

Am I configuring something incorrectly or is this a bug and if it is a bug, are you aware of it and have a fix coming soon as this is completely unusable if I am allowing guests to purchase gift codes.

Let me know if this is clear or you have additional questions.

@jaswrks
Copy link
Contributor

jaswrks commented Mar 6, 2015

@mfritzsche Thanks for the report :-)

Can you please post a copy of:

  • The s2Member payment button and/or Pro-Form shortcode that was used to sell access.
  • The [s2Member-Gift-Codes /] shortcode that you used to generate the gift codes.

Thank you.

@jaswrks
Copy link
Contributor

jaswrks commented Mar 6, 2015

Yes. Thank you. I'll mark this issue as "needs testing". With that information we can make an attempt to reproduce this and get back to you shortly.

@jaswrks
Copy link
Contributor

jaswrks commented Mar 7, 2015

Short-Term Fix

Download this updated copy of sc-gift-codes-in.inc.php and upload it your WordPress installation. Allowing this updated file to overwrite your existing copy of /s2member-pro/includes/classes/sc-gift-codes-in.inc.php.

@jaswrks
Copy link
Contributor

jaswrks commented Mar 7, 2015

Next Release Changelog:

  • (s2Member Pro) Bug Fix for Gift/Redemption Codes: This release of s2Member corrects a bug that impacted the generation of Gift/Redemption Codes whenever they were sold with Specific Post/Page Access. See also this GitHub issue if you'd like additional details.

@mfritzsche
Copy link
Author

I have the latest build installed with the Gift/Redemption Code bug fix and I am seeing that a member I created (for testing purposes) that has not purchased any gift codes is seeing a valid gift code on a page that generates a gift code and is protected by specific post/page access restriction. Is there some setting that I may be missing that is allowing a logged in member who has not purchased a gift code to be able to see this Redemption Code?

The page with the redemption code has this form code:
[s2Member-Gift-Codes discount="27.00" quantity="1" one_click="/member/redeem/" /]

The redemption code post id is 12103 and I have added that to the Specific Post/Page Access Restrictions line (comma separated list -- 12103,12130 -- as there are other pages that are protected).

Again, a brand new member who has NOT purchased redemption codes can see a valid redemption code on the page mentioned above.

image

image

@mfritzsche
Copy link
Author

Any ideas on this? Is there some configuration I am missing that prevents this?

@jaswrks
Copy link
Contributor

jaswrks commented Apr 19, 2015

Please see: #538 (comment)

@wpsharks wpsharks locked and limited conversation to collaborators Apr 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants