Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize.Net Expiration Date Format #576

Closed
jaswrks opened this issue May 21, 2015 · 3 comments
Closed

Authorize.Net Expiration Date Format #576

jaswrks opened this issue May 21, 2015 · 3 comments
Assignees
Milestone

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 21, 2015

Referencing internal ticket:
https://websharks.zendesk.com/agent/tickets/6448

@raamdev writes...

This looks like an Authorize.Net bug report related to the s2Member AIM integration. I looked up the Authorize.Net AIM API reference (see expirationDate here) and it confirms that the format we're sending (see the code here: http://wsharks.com/1KniVNW) is incorrect and NOT a valid format.

Two Different Formats (AIM vs. ARB)

Authorize.Net has two different formats it seems.

The AIM docs here ask for MM-YYYY
http://developer.authorize.net/api/reference/#payment-transactions
I'm guessing this has previously accepted YYYY-MM also, but something changed recently.

The ARB docs here ask for YYYY-MM
http://developer.authorize.net/api/reference/#recurring-billing-create-a-subscription

@jaswrks jaswrks self-assigned this May 21, 2015
@jaswrks jaswrks added this to the Next Release milestone May 21, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue May 21, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue May 21, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue May 21, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented May 21, 2015

Next Release Changelog:

  • (s2Member Pro) Authorize.Net AIM Compat.: This release addresses a compatibility issue that came to light recently, which was actually attributed to a bug in s2Member Pro that has been sliding through unnoticed until now. The format for an expiration date sent to the Authorize.Net AIM API should be MM-YYYY. The format for ARB API calls is YYYY-MM. s2Member Pro was sending YYYY-MM to both APIs. Fixed in this release. Props to @raamdev for investigating this. See also this GitHub issue if you'd like additional details.

@jaswrks
Copy link
Contributor Author

jaswrks commented May 21, 2015

Short-Term Patch Instructions

  • Download this updated file and upload via FTP. Allowing it to replace your existing copy of: s2member-pro/includes/classes/gateways/authnet/authnet-utilities.inc.php
  • Download this updated file and upload via FTP. Allowing it to replace your existing copy of: s2member-pro/includes/classes/gateways/authnet/authnet-checkout-in.inc.php
  • Download this updated file and upload via FTP. Allowing it to replace your existing copy of: s2member-pro/includes/classes/gateways/authnet/authnet-sp-checkout.inc.php
  • Download this updated file and upload via FTP. Allowing it to replace your existing copy of: s2member-pro/includes/classes/gateways/authnet/authnet-update-in.inc.php

@jaswrks jaswrks closed this as completed May 22, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 23, 2015

The latest release of s2Member v150722+ closes this issue.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)

@wpsharks wpsharks locked and limited conversation to collaborators Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant