Stripe issue with multiple checkout options

[bryanthankins]

When creating multiple checkout options on stripe pro-form, choosing a pay option, and entering a duplicate email, the duplicate email validation does not display and the form resets to the free option.

Here are the steps to reproduce:

1. Install a fresh wordpress
2. Install a fresh s2Member pro
3. Configure Stripe test private and public key
4. Create a Membership Options page
5. Add the following to your membership options page:

[s2Member-Pro-Stripe-Form]
[s2Member-Pro-Stripe-Form register="1" level="0" ccaps="" desc="Signup now, it's Free!" tp="0" tt="D" captcha="clean"/]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="$10 USD / Monthly (recurring charge, for ongoing access)" cc="USD" ta="0" tp="0" tt="D" ra="10" rp="1" rt="M" rr="1" coupon="" accept_coupons="0" default_country_code="US" captcha="0" /]
[s2Member-Pro-Stripe-Form level="2" ccaps="" desc="$99 USD / Yearly (recurring charge, for ongoing access)" cc="USD" ta="0" tp="0" tt="D" ra="99" rp="1" rt="Y" rr="1" coupon="" accept_coupons="0" default_country_code="US" captcha="0"/]
[/s2Member-Pro-Stripe-Form]

6. Logout and go to the member ship options page.
7. Choose the $10/month signup
8. Fill out the fields
9. IMPORTANT: When filling out the email address, pick one that has already been used by another user
10. Add a billing method using the test stripe credit card
11. Press submit
12. You will be redirected back to a blank form and it will choose the free checkout option and not give you your validation error.

NOTE: This error only happens with the Stripe Pro forms and not with the Paypal pro forms. Also, it does not happen if you choose the "Free" checkout option. Everything works correctly when you do that.

[patdumond]

I have verified that this occurs on my test site using the parameters Bryant has set here.

[jaswrks]

@bryanthankins @patdumond This appears to be a duplicate of #569 (i.e., indirectly related). Would you mind applying the patch provided in #569 and let me know if this still occurs on your end please?

[patdumond]

I'm getting a "File Not Found" error on that patch, Jason.

[patdumond]

Jason,

Tested the patch to #569 for this issue. I tested 3 times yesterday and got no error message when using a duplicate email. The transaction failed, but I was simply returned to a blank form: no error message at the top.

Then I went in today to test a different issue and accidentally used a duplicate email (not the same email I used yesterday -- which was definitely in the database, I triple-checked) and got an error message that the email address already existed. I tested the same address I used yesterday again and got an error message. So, it appears to be fixed. I must not have been "holding my mouth right" yesterday, as my mother used to say.

[jaswrks]

So, it appears to be fixed. I must not have been "holding my mouth right" yesterday, as my mother used to say.

@patdumond Thank you! So it does appear that both issues were corrected by #569 then? Sorry, just want to make sure that I understand. If not, I will open this back up and run another round of tests.

[bryanthankins]

Thanks for the fix and the great product!

[bryanthankins]

This fix resolves the issue of not seeing the error message, but it still resets the form to the free option if you have selected another option.

[patdumond]

There is more information on what Bryant said above in this ticket. I elevated the ticket to Level 2 to make sure you see it one way or another.

[jaswrks]

I elevated the ticket to Level 2 to make sure you see it one way or another.

@patdumond Thank you. I am reviewing now.

[jaswrks]

@bryanthankins @patdumond Thank you for identifying a remaining problem with this. I found the underlying issue (in JavaScript) and it has been corrected in the development copy. It will come soon with the next release of s2Member Pro.

Short-Term Patch

• Download this updated file and upload via FTP. Allowing it to override your existing copy of s2member-pro/includes/separates/gateways/stripe/stripe-min.js
• IMPORTANT: Clear your browser cache (i.e., temp files) before re-testing.

[jaswrks]

Next Release Changelog:

• (s2Member Pro) Stripe Bug Fix: This release corrects a bug in s2Member's Stripe Pro-Forms, related to having multiple Checkout Options. The bug resulted in a missing error message whenever one of the Checkout Options was submitted incorrectly, and also resulted in the default Checkout Option being magically selected instead of the one that a customer was working with. Props to @patdumond and @bryanthankins. See: this GitHub issue if you'd like additional details.

[bryanthankins]

@jaswsinc Thanks for the quick fix on this and the shout out in the release notes. I have confirmed that this patch does indeed solve the problem.