Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: support of es module #218

Closed
2 of 4 tasks
myfreeer opened this issue Apr 1, 2021 · 1 comment · Fixed by #995
Closed
2 of 4 tasks

BREAKING: support of es module #218

myfreeer opened this issue Apr 1, 2021 · 1 comment · Fixed by #995
Assignees
Labels
enhancement New feature or request

Comments

@myfreeer
Copy link
Member

myfreeer commented Apr 1, 2021

This should be marked as a BREAKING CHANGE, since supporting esm is currently infectious, everything depends on it would have to move to esm after this.
A release must be created before this.

Things to wait for:

Things to change:

  • worker-pool.spec.ts (__dirname)
  • package-lock-resolved.js (__dirname)
  • delay-calc-worker.js (require)
  • copy-src.js (__dirname)
  • tsconfig.json
  • package.json

Things breaking by this:

@myfreeer
Copy link
Member Author

myfreeer commented May 5, 2021

Maybe we can use rollup to package p-queue to commonjs module again

@myfreeer myfreeer added the enhancement New feature or request label Nov 7, 2021
myfreeer added a commit that referenced this issue Oct 5, 2024
* add js suffix for all relative imports
* use type import and export

Note this is not marked as breaking change since it still compiles on commonjs.

Part of #218
myfreeer added a commit that referenced this issue Oct 5, 2024
@myfreeer myfreeer changed the title meta: support of es module BREAKING: support of es module Oct 5, 2024
@myfreeer myfreeer self-assigned this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant