Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gotoOptions param and update README.md #61

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

myisaak
Copy link
Contributor

@myisaak myisaak commented Apr 23, 2023

This PR allows one to include the following code that configures puppeteer to wait until "networkIdle0". This fixes the issue I had, where I wasn't able to configure the "waitUntil" prop.

new PuppeteerPlugin({
  // ....
  gotoOptions: { waitUntil: "networkIdle0" },
})

@s0ph1e
Copy link
Member

s0ph1e commented Jul 25, 2023

Hi @myisaak 👋

First of all, thank you for your contribution 👍
I'm very sorry for the super-late response, I've somehow lost this PR.
Going to test it and if everything works fine - merge and release in the nearest few days

@s0ph1e s0ph1e merged commit bf37013 into website-scraper:master Jul 25, 2023
@s0ph1e
Copy link
Member

s0ph1e commented Jul 25, 2023

Released in version 1.1.0
Thank you again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants