Add tokio support. #111
Merged
Add tokio support. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
reviewed
Apr 7, 2017
src/stream.rs
Outdated
| @@ -49,6 +57,7 @@ impl<R, W> Splittable for ReadWritePair<R, W> | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(not(feature="async"))] | |||
There was a problem hiding this comment.
That means the async feature isn't additive, no?
There was a problem hiding this comment.
@nox I wish this would work but I'm currently trying to figure out a way to get both (I mean it's only disabled because I got a conflicting trait impl error but then I still couldn't use split on a TCP stream)
Closed
illegalprime
force-pushed
the
feat/tokio
branch
2 times, most recently
from
9aab73d
to
7a64f25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us have efficient servers and be able to multiplex ordinarily blocking code.
Fixes #88 and will help with servo/servo#16236