Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket.upgradeReq property is missing or not set in later versions of ws. #1666

Closed
dashanchang opened this issue Dec 2, 2019 · 1 comment
Closed

websocket.upgradeReq property is missing or not set in later versions of ws. #1666

dashanchang opened this issue Dec 2, 2019 · 1 comment

Comments

@dashanchang
Copy link

Hi ws team,

I've been using ws with node.js for a long time. I have noticed the later versions of ws are missing one of the import properties: upgradeReq, causing apps using it to fail.

Adding one line code at line 288 of websocket-server.js would fix it:
ws.upgradeReq = req;

Thanks
Dashan Chang
@lpinca
Copy link
Member

lpinca commented Dec 3, 2019

See #1099. This was changed in version 3.0.0

@lpinca lpinca closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpinca @dashanchang